fix: allow activeProps to infer component props #2347
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit bace58c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
chorobin
force-pushed
the
create-link-types
branch
from
9368534
to
29e2264
Compare
| export type UseLinkPropsOptions< | ||
| TRouter extends AnyRouter = RegisteredRouter, | ||
| TFrom extends RoutePaths<TRouter['routeTree']> | string = string, | ||
| TTo extends string | undefined = '.', | ||
| TMaskFrom extends RoutePaths<TRouter['routeTree']> | string = TFrom, | ||
| TMaskTo extends string = '.', | ||
| > = ActiveLinkOptions<TRouter, TFrom, TTo, TMaskFrom, TMaskTo> & | ||
| React.AnchorHTMLAttributes<HTMLAnchorElement> | ||
| > = ActiveLinkOptions<'a', TRouter, TFrom, TTo, TMaskFrom, TMaskTo> & |
There was a problem hiding this comment.
about the 'a': please see this comment #2092 (comment)
There was a problem hiding this comment.
This works with 'a' properly now ;)
There was a problem hiding this comment.
cool!
@mirague check this out
…into create-link-types
| props: Parameters<typeof Button>[0], | ||
| ref: React.Ref<HTMLButtonElement>, | ||
| ) => { | ||
| return <Button {...props} ref={ref} component={Link} /> |
There was a problem hiding this comment.
and how does this button then get access to the to?
There was a problem hiding this comment.
Does it need to? Its there at runtime but its not been typed. I'm not sure the use case for this though
There was a problem hiding this comment.
what if you want to navigate to to upon button click?
There was a problem hiding this comment.
We have a similar usecase for getting access to the active: boolean property to render a different variant of the component based on the Link being active.
(activeProps doesn't seem to propagate as expected)
chorobin
force-pushed
the
create-link-types
branch
from
bdff996
to
bace58c
Compare
Fixes #2079